allow setting the storageClass for /tmp and /app/tmp volumes #89
Conversation
🦋 Changeset detectedLatest commit: dfcf786 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Should I use a changeset for this? |
|
Hi @johanneskastl , indeed every change to the helm-chart needs a changeset, as with it we track the changelog after a release. I've added one for you! This PR is a good default but I would imagine some people would want to set a different storageClassName for the tmp volumes as they have different use-cases. We could add a new tmpStorageClassName which is empty by default and do a coalesce? |
|
Thanks for adding the changeset. Funny name! I agree it might be a good idea to offer that functionality, but I have no time in the next couple of days to implement this. So for now I would propose to merge this and add the different storageClass functionality later on. |
|
Any news on this? Could this be merged (after a rebase, of course)? Or are there any objections? |
…orageClassName for /tmp and /app/tmp volumes, if it is defined
johanneskastl
force-pushed
the
20240204_storageClassName_for_tmp_and_app-tmp_volumes
branch
from
ee91066
to
7a11faa
Compare
Sorry for the noise, I had some minutes and enhanced this PR finally to support either a @oliverguenther Is this how you had it in mind? |
|
Hi @johanneskastl , thanks a lot for the update. Yes this is exactly what I had in mind. I'll release this today 👍 |
* charts/openproject/templates/_helpers.tpl: use .Values.persistence.storageClassName for /tmp and /app/tmp volumes, if it is defined * charts/openproject/values.yaml: define empty tmpStorageClassName * Create gorgeous-snakes-drum.md * Update gorgeous-snakes-drum.md --------- Co-authored-by: Oliver Günther <[email protected]>
|
Released as 5.4.0 https://github.com/opf/helm-charts/releases/tag/openproject-5.4.0. Sorry for the delay! |
|
FYI As I'm also about to merge PR #104 , we will move the value from This will be released as chart 7.0 even though it was just release today to adhere with semantic versioning. I'd recommend you update directly to that and use the updated syntax |
Thanks for the warning, I am currently upgrading to 6.0.0 but will upgrade to 7.0.0 once it was released... |
|
FYI 7.0.0 is now released https://github.com/opf/helm-charts/releases/tag/openproject-7.0.0 |
In my case there was no change necessary, as I only set the |
charts/openproject/templates/_helpers.tpl: use .Values.persistence.storageClassName for /tmp and /app/tmp volumes, if it is defined